feat(core): allow local execution transpiler overriding with env var #16037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yharaskrik
requested review from
vsavkin,
FrozenPandaz and
AgentEnder
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
requested changes
Apr 3, 2023
yharaskrik
requested review from
bcabanes,
isaacplmann and
juristr
as code owners
Done! |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently the transpiler being picked for local execution is entirely depending on if
@swc-node/register'is installed or not. While this works for the overwhelmingly large majority of cases there are times when we may want to force the transpiling to use ts-node even though swc-node is installed. For example in our CI, we use CircleCI arm64 resources to run all of our build steps (as they end up cheaper than the x86/amd64 resources) except for when we dockerize our servers, we dockerize our servers on x86 Docker containers (since they are being deployed to x86 servers so we can't* build them on arm resources). This means that if we have@swc-node/registerinstalled then when our dependencies are installed on arm resources we have arm swc native code compiled which doesn't run when we call local executions in our step that dockerizes (since its x86 and we do not have x86 swc compiled binaries).Expected Behavior
This PR would allow us to set an env var to tell Nx to use
ts-nodeeven though swc-register is installed. This allows us to have local executions happening for all cases it can work, like dev'ing locally, or on most of our CI steps, but then set it to ts-node when we know we need it to fallback.There may be another way to get around this I am missing so if there is I am more than happy to close this and do that!
Related Issue(s)
Fixes #